drop redundant instance_ member#360
Merged
Merged
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
|
Tick the box to add this pull request to the merge queue (same as
|
asymingt
reviewed
Jun 29, 2026
| instance_->passInNode(node_); | ||
| instances_[&*instance_] = nodelet_name.c_str(); | ||
| instance->passInNode(node_); | ||
| instances_[&*instance] = nodelet_name.c_str(); |
There was a problem hiding this comment.
At a minimum I think you should do this:
Suggested change
| instances_[&*instance] = nodelet_name.c_str(); | |
| instances_[instance.get()] = nodelet_name.c_str(); |
But really, we shoudl probably be using:
QMap<std::shared_ptr<rqt_gui_cpp::Plugin>, QString> instances_;
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
asymingt
approved these changes
Jul 10, 2026
Contributor
Author
|
Pulls: #360
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Opus 4.7